Skip to content

[Misc] Remove unused tl_pipeline_sync.#1566

Merged
LeiWang1999 merged 2 commits intotile-ai:mainfrom
c8ef:patch-1
Dec 29, 2025
Merged

[Misc] Remove unused tl_pipeline_sync.#1566
LeiWang1999 merged 2 commits intotile-ai:mainfrom
c8ef:patch-1

Conversation

@c8ef
Copy link
Contributor

@c8ef c8ef commented Dec 29, 2025 •
edited by coderabbitai bot
Loading

As discussed in the WeChat group, this annotation key is unused and can be safely removed.

Summary by CodeRabbit

  • Bug Fixes
    • Improved pipelined loop detection to recognize loops without requiring a specific annotation, allowing more loops to be identified as pipelined.

✏️ Tip: You can customize this high-level summary in your review settings.

c8ef added 2 commits December 29, 2025 22:04
@c8ef
Remove unused sync annotation setting
8e4dca7 
Removed setting of 'tl_pipeline_sync' annotation if sync is empty.
@c8ef
Update nested_loop_checker.py
a6906c2
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes remove all handling of the tl_pipeline_sync annotation from the pipeline processing system. The annotation is deleted from both the pipeline annotation map construction and from the pipelined loop detection logic. Other pipeline annotations remain unaffected.

Changes

Cohort / File(s) Summary
Pipeline sync annotation removal
src/ir.cc, tilelang/analysis/nested_loop_checker.py		 Removes tl_pipeline_sync from annotation processing: deleted from the annotation map in ir.cc; removed from the is_pipelined_for detection set in nested_loop_checker.py. Other pipeline annotations (num_stages, tl_pipeline_order, tl_pipeline_stage, tl_pipeline_group) remain processed as before.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The sync annotation hops away,
Two files trimmed this lovely day,
Pipeline checks now light and spry,
Simpler logic—reason why! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the unused tl_pipeline_sync annotation from two files (src/ir.cc and tilelang/analysis/nested_loop_checker.py).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 124583b and a6906c2.

📒 Files selected for processing (2)
  • src/ir.cc
  • tilelang/analysis/nested_loop_checker.py
💤 Files with no reviewable changes (1)
  • src/ir.cc
🔇 Additional comments (1)
tilelang/analysis/nested_loop_checker.py (1)

14-14: Removal of "tl_pipeline_sync" annotation is safe—no code uses it.

The annotation is not referenced anywhere in the codebase, so removing it from the anno_keys list has no impact on existing functionality.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@c8ef
Copy link
Contributor Author

c8ef commented Dec 29, 2025

cc @LeiWang1999 @chengyupku

@LeiWang1999 LeiWang1999 merged commit f4ad7d3 into tile-ai:main Dec 29, 2025
3 checks passed
@c8ef c8ef deleted the patch-1 branch December 29, 2025 15:34
@kurisu6912 kurisu6912 mentioned this pull request Feb 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeiWang1999 LeiWang1999 LeiWang1999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c8ef @LeiWang1999